76548 0 true 2009-11-28T16:37:53-05:00 76511 2009-11-17T00:00:00-05:00 55781 31 pvector 1 41284 checked-in pvector 2009-12-03T22:49:35-05:00 76548 aSydiK F1LT3R aSydiK http://processing-js.lighthouseapp.com/projects/41284/tickets/31 0.1 release date 0 false 2009-11-14T16:25:33-05:00 76511 --- {} 55781 31 pvector 0 41284 review-requested 2009-11-14T16:25:37-05:00 76511 F1LT3R F1LT3R http://processing-js.lighthouseapp.com/projects/41284/tickets/31 0.1 release date 76548 0 false 2009-11-14T21:46:38-05:00 76511 --- :assigned_user: 55781 31 pvector 0 41284 review-requested 2009-11-14T21:46:40-05:00 76511 F1LT3R F1LT3R aSydiK http://processing-js.lighthouseapp.com/projects/41284/tickets/31 0.1 release date 76548 0 true 2009-11-14T22:25:26-05:00 76511 --- :milestone: 55781 :state: review-requested 55749 31 pvector 0 41284 review-needs-work 2009-11-14T22:25:27-05:00 76511 F1LT3R F1LT3R aSydiK http://processing-js.lighthouseapp.com/projects/41284/tickets/31 0.2 release date 76548 0 <h1>Status</h1> <b>Good:</b> What you've done so for is awesome and works very well.<br /> <b>Bad:</b> But until we have the Object kinks worked out I think it would be counter-productive for the community if I push it. Let's find a time to get together this week and nail this one. <div><h1>Status</h1> <b>Good:</b> What you've done so for is awesome and works very well.<br> <b>Bad:</b> But until we have the Object kinks worked out I think it would be counter-productive for the community if I push it. Let's find a time to get together this week and nail this one.</div> true 2009-11-14T22:46:30-05:00 76511 --- {} 55749 31 pvector 0 41284 review-needs-work 2009-11-14T22:48:01-05:00 76511 F1LT3R F1LT3R aSydiK http://processing-js.lighthouseapp.com/projects/41284/tickets/31 0.2 release date 76548 0 false 2009-11-15T00:56:39-05:00 76511 --- :tag: 55749 31 pvector 0 41284 review-needs-work pvector 2009-11-15T00:56:46-05:00 76548 aSydiK F1LT3R aSydiK http://processing-js.lighthouseapp.com/projects/41284/tickets/31 0.2 release date 76548 0 <pre> function PVectorAdd(){ arguments = arguments[0][0] ? arguments[ 0 ] : arguments ; if (arguments.length == 3){ this.x += arguments[0]; this.y += arguments[1]; this.z += arguments[2]; } else if (arguments.length == 1){ this.x += arguments[0].x; this.y += arguments[0].y; this.z += arguments[0].z; } else if (arguments.length == 2){ var a = arguments; return p.PVector( a[0].x + a[1].x, a[0].y + a[1].y, a[0].z + a[1].z ); } } p.PVector = function PVector(){ return new vectorStuff( arguments ); } p.PVector.add = PVectorAdd; function vectorStuff(){ arguments = arguments[0]; this.x = arguments[ 0 ]; this.y = arguments[ 1 ]; this.z = arguments[ 2 ] || 0; this.add = function(){ PVectorAdd.call( this, arguments ); }; } </pre> <div><pre> function PVectorAdd(){ arguments = arguments[0][0] ? arguments[ 0 ] : arguments ; if (arguments.length == 3){ this.x += arguments[0]; this.y += arguments[1]; this.z += arguments[2]; } else if (arguments.length == 1){ this.x += arguments[0].x; this.y += arguments[0].y; this.z += arguments[0].z; } else if (arguments.length == 2){ var a = arguments; return p.PVector( a[0].x + a[1].x, a[0].y + a[1].y, a[0].z + a[1].z ); } } p.PVector = function PVector(){ return new vectorStuff( arguments ); } p.PVector.add = PVectorAdd; function vectorStuff(){ arguments = arguments[0]; this.x = arguments[ 0 ]; this.y = arguments[ 1 ]; this.z = arguments[ 2 ] || 0; this.add = function(){ PVectorAdd.call( this, arguments ); }; } </pre></div> false 2009-11-18T00:58:06-05:00 76511 --- {} 55749 31 pvector 0 41284 review-needs-work pvector 2009-11-18T00:59:32-05:00 76511 F1LT3R F1LT3R aSydiK http://processing-js.lighthouseapp.com/projects/41284/tickets/31 0.2 release date 76548 0 http://github.com/aSydiK/processing-js/commit/8bf574637d1deaf2ab75b73d5d8c925a48c7ac48 <div><p><a href= "http://github.com/aSydiK/processing-js/commit/8bf574637d1deaf2ab75b73d5d8c925a48c7ac48"> http://github.com/aSydiK/processing-js/commit/8bf574637d1deaf2ab75b...</a></p></div> false 2009-11-23T22:01:39-05:00 76511 --- :state: review-needs-work 55749 31 pvector 0 41284 review-requested pvector 2009-11-23T22:01:40-05:00 76548 aSydiK F1LT3R aSydiK http://processing-js.lighthouseapp.com/projects/41284/tickets/31 0.2 release date 76548 0 <h1>Status</h1> <b>Good:</b> Great work!!! That took some commitment to get that done but you stuck with it, and it's working well. It's in!<br /> <b>Bad:</b> The code is longer than it needs to be, a lot of repetition that can be reduced and generally tightened up, but that's fairly trivial and can be looked at another time, perhaps as a contrib. You are using typeof like this.. <pre> if( (typeof whatever) == 'string' ){} </pre> You can do this... <pre> if( typeof whatever == 'string' ){} </pre> Nice work! <div><h1>Status</h1> <b>Good:</b> Great work!!! That took some commitment to get that done but you stuck with it, and it's working well. It's in!<br> <b>Bad:</b> The code is longer than it needs to be, a lot of repetition that can be reduced and generally tightened up, but that's fairly trivial and can be looked at another time, perhaps as a contrib. You are using typeof like this.. <pre> if( (typeof whatever) == 'string' ){} </pre> You can do this... <pre> if( typeof whatever == 'string' ){} </pre> Nice work!</div> true 2009-11-24T10:54:35-05:00 76511 --- :milestone: 55749 :state: review-requested 55781 31 pvector 0 41284 review-looks-good pvector 2009-11-24T10:54:36-05:00 76511 F1LT3R F1LT3R aSydiK http://processing-js.lighthouseapp.com/projects/41284/tickets/31 0.1 release date 76548 0 I changed the implementation a lot. // PVector instantiation var PVector = function (x, y, z){ this.x = x || 0; this.y = y || 0; this.z = z || 0; }, createSimplePVectorMethod = function (method) { return function (v1, v2) { var v = v1.get(); v[method](v2); return v; }; }, method; PVector.angleBetween = function (v1, v2){ return Math.acos(v1.dot(v2) / (v1.mag() * v2.mag())); }; // Common vector operations for PVector PVector.prototype = { set: function(v, y, z){ if (arguments.length === 1){ this.set(v.x || v[0], v.y || v[1], v.z || v[2]); }else{ this.x = v; this.y = y; this.z = z; } }, get: function get(){ return new PVector(this.x, this.y, this.z); }, mag: function mag(){ return Math.sqrt( this.x * this.x + this.y * this.y + this.z * this.z ); }, add: function(v, y, z){ if( arguments.length === 3 ){ this.x += v; this.y += y; this.z += z; }else if( arguments.length === 1 ){ this.x += v.x; this.y += v.y; this.z += v.z; } }, sub: function(v, y, z){ if( arguments.length === 3 ){ this.x -= v; this.y -= y; this.z -= z; }else if( arguments.length === 1 ){ this.x -= v.x; this.y -= v.y; this.z -= v.z; } }, mult: function(v){ if( typeof v === 'number' ){ this.x *= v; this.y *= v; this.z *= v; }else if( typeof v === 'object' ){ this.x *= v.x; this.y *= v.y; this.z *= v.z; } }, div: function(v){ if( typeof v === 'number' ){ this.x /= v; this.y /= v; this.z /= v; }else if( typeof v === 'object' ){ this.x /= v.x; this.y /= v.y; this.z /= v.z; } }, dist: function(v){ var dx = this.x - v.x, dy = this.y - v.y, dz = this.z - v.z; return Math.sqrt( dx*dx + dy*dy + dz*dz ); }, dot: function(v, y, z){ var num; if( arguments.length === 3 ){ num = this.x * v + this.y * y + this.z * z; }else if( arguments.length === 1 ){ num = this.x * v.x + this.y * v.y + this.z * v.z; } return num; }, cross: function(v){ var crossX = this.y * v.z - v.y * this.z, crossY = this.z * v.x - v.z * this.x, crossZ = this.x * v.y - v.x * this.y; return new PVector( crossX, crossY, crossZ ); }, normalize: function(){ var m = this.mag(); if( m > 0 ){ this.div( m ); } }, limit: function ( high ){ if( this.mag() > high ){ this.normalize(); this.mult( high ); } }, array: function array(){ return [this.x, this.y, this.z]; } }; for (method in PVector.prototype) { if (PVector.prototype.hasOwnProperty(method)) { PVector[method] = createSimplePVectorMethod(method); } } p.PVector = PVector; <div><p>I changed the implementation a lot.</p> <pre> <code>// PVector instantiation var PVector = function (x, y, z){ this.x = x || 0; this.y = y || 0; this.z = z || 0; }, createSimplePVectorMethod = function (method) { return function (v1, v2) { var v = v1.get(); v[method](v2); return v; }; }, method; PVector.angleBetween = function (v1, v2){ return Math.acos(v1.dot(v2) / (v1.mag() * v2.mag())); }; // Common vector operations for PVector PVector.prototype = { set: function(v, y, z){ if (arguments.length === 1){ this.set(v.x || v[0], v.y || v[1], v.z || v[2]); }else{ this.x = v; this.y = y; this.z = z; } }, get: function get(){ return new PVector(this.x, this.y, this.z); }, mag: function mag(){ return Math.sqrt( this.x * this.x + this.y * this.y + this.z * this.z ); }, add: function(v, y, z){ if( arguments.length === 3 ){ this.x += v; this.y += y; this.z += z; }else if( arguments.length === 1 ){ this.x += v.x; this.y += v.y; this.z += v.z; } }, sub: function(v, y, z){ if( arguments.length === 3 ){ this.x -= v; this.y -= y; this.z -= z; }else if( arguments.length === 1 ){ this.x -= v.x; this.y -= v.y; this.z -= v.z; } }, mult: function(v){ if( typeof v === 'number' ){ this.x *= v; this.y *= v; this.z *= v; }else if( typeof v === 'object' ){ this.x *= v.x; this.y *= v.y; this.z *= v.z; } }, div: function(v){ if( typeof v === 'number' ){ this.x /= v; this.y /= v; this.z /= v; }else if( typeof v === 'object' ){ this.x /= v.x; this.y /= v.y; this.z /= v.z; } }, dist: function(v){ var dx = this.x - v.x, dy = this.y - v.y, dz = this.z - v.z; return Math.sqrt( dx*dx + dy*dy + dz*dz ); }, dot: function(v, y, z){ var num; if( arguments.length === 3 ){ num = this.x * v + this.y * y + this.z * z; }else if( arguments.length === 1 ){ num = this.x * v.x + this.y * v.y + this.z * v.z; } return num; }, cross: function(v){ var crossX = this.y * v.z - v.y * this.z, crossY = this.z * v.x - v.z * this.x, crossZ = this.x * v.y - v.x * this.y; return new PVector( crossX, crossY, crossZ ); }, normalize: function(){ var m = this.mag(); if( m &gt; 0 ){ this.div( m ); } }, limit: function ( high ){ if( this.mag() &gt; high ){ this.normalize(); this.mult( high ); } }, array: function array(){ return [this.x, this.y, this.z]; } }; for (method in PVector.prototype) { if (PVector.prototype.hasOwnProperty(method)) { PVector[method] = createSimplePVectorMethod(method); } } p.PVector = PVector;</code> </pre></div> true 2009-11-28T16:37:53-05:00 76511 --- {} 55781 31 pvector 0 41284 review-looks-good pvector 2009-11-29T18:45:52-05:00 77886 sephr F1LT3R aSydiK http://processing-js.lighthouseapp.com/projects/41284/tickets/31 0.1 release date 76548 0 Your new re-written code breaks some of the functionality of PVector based on the [Processing Reference](http://processing.org/reference/PVector_add_.html "Processing Reference"). Specifically items like PVector.add(v1, v2). <div><p>Your new re-written code breaks some of the functionality of PVector based on the <a href= "http://processing.org/reference/PVector_add_.html" title= "Processing Reference">Processing Reference</a>. Specifically items like PVector.add(v1, v2).</p></div> true 2009-11-29T17:57:33-05:00 76511 --- {} 55781 31 pvector 0 41284 review-looks-good pvector 2009-11-29T17:57:33-05:00 76548 aSydiK F1LT3R aSydiK http://processing-js.lighthouseapp.com/projects/41284/tickets/31 0.1 release date 76548 0 aSydiK, the problem was that my `createSimplePVectorMethod()` function was returning the void result instead of returning the vector itself. I have fixed the code. <div><p>aSydiK, the problem was that my <code>createSimplePVectorMethod()</code> function was returning the void result instead of returning the vector itself. I have fixed the code.</p></div> true 2009-11-29T18:46:47-05:00 76511 --- {} 55781 31 pvector 0 41284 review-looks-good pvector 2009-11-29T18:46:49-05:00 77886 sephr F1LT3R aSydiK http://processing-js.lighthouseapp.com/projects/41284/tickets/31 0.1 release date 76548 0 true 2009-12-03T22:49:33-05:00 76511 --- :state: review-looks-good 55781 31 pvector 0 41284 checked-in pvector 2009-12-03T22:49:35-05:00 76548 aSydiK F1LT3R aSydiK http://processing-js.lighthouseapp.com/projects/41284/tickets/31 0.1 release date